-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make recovery action retry timeout configurable #14022
Conversation
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
…e it dynamic Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
e8c0b87
to
c2786b4
Compare
❌ Gradle check result for e8c0b87: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Strange that the indices.recovery.internal_action_retry_timeout
setting was marked as Dynamic
and NodeScope
but there wasn't a way to change these settings dynamically through Cluster Settings API.
❌ Gradle check result for c2786b4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14022 +/- ##
============================================
+ Coverage 71.42% 71.60% +0.18%
- Complexity 59978 61376 +1398
============================================
Files 4985 5073 +88
Lines 282275 288528 +6253
Branches 40946 41776 +830
============================================
+ Hits 201603 206593 +4990
- Misses 63999 64883 +884
- Partials 16673 17052 +379 ☔ View full report in Codecov by Sentry. |
This reverts commit a4f00d2. Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
1af6b1c
to
2f29b43
Compare
❌ Gradle check result for 2f29b43: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
❌ Gradle check result for 2f29b43: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 92efc25: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 92efc25: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-14022-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5bad14cf06b4fc1c6f0d5ff03a72f06bb38d1026
# Push it to GitHub
git push --set-upstream origin backport/backport-14022-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…4022) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
…4022) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
…4022) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
…4022) (opensearch-project#14063) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> Signed-off-by: kkewwei <kkewwei@163.com>
…4022) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Description
Add recovery action retry setting . This allows changing it dynamically.
Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.